Address Dan's review feedback: shorter minimumReleaseAge + precise wording#757
Merged
Address Dan's review feedback: shorter minimumReleaseAge + precise wording#757
Conversation
Two small follow-ups: 1. minimumReleaseAge: 24 hours -> 1 hour. Dan flagged that 24h is overcautious for first-party Stacklok releases. Renovate itself only runs every 4h so 1h is effectively close to 0 while still protecting against same-day yanks/reverts. 2. prBodyNotes: drop "regenerates" where we're actually just syncing. Now precisely: "syncs reference assets (CLI help, Swagger) and regenerates the CRD MDX pages" for toolhive. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Renovate configuration for upstream-release docs automation by reducing the delay before new upstream releases are eligible for PRs and by clarifying PR body wording around what the workflow does for stacklok/toolhive.
Changes:
- Reduce
minimumReleaseAgefor the upstream projects rule from24 hoursto1 hour. - Refine
prBodyNoteswording to distinguish “syncs reference assets” vs “regenerates CRD MDX pages”.
Previous behavior pulled every non-bot commit author from the upstream
release range and passed them to `gh pr edit --add-reviewer` as a
single comma-separated list. GitHub rejects reviewer requests for
non-collaborators with 422, and because the API treats the list
atomically, one community contributor in the range would fail the
entire call and drop all valid reviewers with it.
Fix:
- Probe each candidate with `gh api repos/<repo>/collaborators/<user>`
before adding. 204 -> keep; 404 -> skip.
- Emit a separate `skipped` output listing non-collaborator
contributors so the PR body can acknowledge them by name
("Other release contributors ... Thanks for the contribution!")
without actually requesting review from them.
Pre-existing bot-regex filter runs first so we don't waste API calls
on [bot] users.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
danbarr
previously approved these changes
Apr 21, 2026
Filtering out non-collaborator reviewers stays (prevents the 422 whole-call-failure). But mentioning them by name in the augmented PR body adds notification surface we don't want. Silently skip. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
danbarr
approved these changes
Apr 21, 2026
This was referenced Apr 21, 2026
rdimitrov
added a commit
that referenced
this pull request
Apr 21, 2026
Two fixes to get the Renovate-triggered skill runs actually working
and observable:
1. `allowed_bots: renovate` — without this, claude-code-action
refuses to run any workflow initiated by a bot identity with
"Workflow initiated by non-human actor: renovate (type: Bot)."
This is the action's default safety behavior. We deliberately
allow Renovate (the whole point of the pipeline) but leave the
list narrow — other bots still blocked.
2. `track_progress: true` + `display_report: true` — these expose
live progress during long skill runs:
- track_progress posts a sticky tracking comment on the PR that
updates as the skill works through each phase
- display_report surfaces the Claude Code Report in the Actions
Step Summary as the step runs, not just after completion
Skill runs that previously went silent for 20-45 min now stream
live status.
The track_progress change was supposed to ship in #757 but was
pushed after the squash-merge and got orphaned on the branch.
Seen on run 24743776702 — Renovate PR #759's workflow failed with
the bot-actor rejection.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four follow-ups to #748:
1.
minimumReleaseAge: 24 hours→1 hourDan flagged that 24h is overcautious for first-party Stacklok releases. Renovate itself only runs every 4h so
1 houris effectively close to0in the common case while still protecting against same-day yanks/reverts.2.
regenerateswording inprBodyNotesOne leftover instance that missed the earlier terminology pass. Now precisely:
3. Filter reviewers to repo collaborators
Previous behavior passed every non-bot commit author to
gh pr edit --add-revieweras a single comma-separated list. GitHub rejects non-collaborator reviewer requests with 422, and because the API treats the list atomically, one community contributor in the range would fail the whole call and drop all valid reviewers with it.Fix: probe each candidate with
gh api repos/<repo>/collaborators/<user>before adding. 204 → keep; 404 → silently skip. Prevents both the notification-to-strangers case AND the whole-call-failure case.4. Real-time skill progress visibility
The skill step previously went silent for 20-45 min with no way to observe progress without waiting for logs to finalize. Two
claude-code-actioninputs expose live status:track_progress: true— posts a sticky tracking comment on the PR that updates as the skill works through each phasedisplay_report: true— surfaces the Claude Code Report in the Actions Step Summary as the step runsOperators watching a run now see progress from either the PR page or the run view, in real time.
Testing
renovate.json🤖 Generated with Claude Code